-
Notifications
You must be signed in to change notification settings - Fork 4
feat: diode-sdk-python 1.0.0-rc #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
leoparente
approved these changes
Apr 23, 2025
Contributor
leoparente
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces OAuth2-based authentication to the Diode SDK, replacing the previous API key mechanism. It also includes updates to the supported entities, dependency requirements, and test cases. Below is a summary of the most important changes grouped by theme.
Authentication Updates
_DiodeAuthenticationand_authenticatemethods to handle token retrieval and metadata updates. (netboxlabs/diode/sdk/client.py) [1] [2]DIODE_CLIENT_IDandDIODE_CLIENT_SECRETfor OAuth2 credentials. (README.md,netboxlabs/diode/sdk/client.py) [1] [2]Retry Mechanism
UNAUTHENTICATEDerrors, with a configurable maximum number of retries (DIODE_MAX_AUTH_RETRIES). (netboxlabs/diode/sdk/client.py)Documentation and Supported Entities
README.mdto include a comprehensive set of object types. (README.md)README.md)Dependency Updates
pyproject.tomlto allow more flexible versioning forcertifi,grpcio, andgrpcio-status. (pyproject.toml)Test Suite Enhancements
tests/test_client.py) [1] [2]These changes significantly enhance the SDK's authentication mechanism, improve its documentation, and ensure robust testing for the new features.